From: Giovanni Campagna Date: Mon, 26 Nov 2012 21:30:20 +0000 (+0100) Subject: Telepathy: ignore errors from ack_all_pending_messages() X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~5358 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=d517c13d7aedd9c2f1ebf8bc362ac1143d0a09a4;p=gnome-shell.git Telepathy: ignore errors from ack_all_pending_messages() Invalid ID errors from that function are normal, because the set of IDs to acknowledge may not match the set in the connection manager due to race conditions. This is also what empathy does. https://bugzilla.gnome.org/show_bug.cgi?id=683449 --- diff --git a/js/ui/components/telepathyClient.js b/js/ui/components/telepathyClient.js index b41aa5f9f..ddceb345d 100644 --- a/js/ui/components/telepathyClient.js +++ b/js/ui/components/telepathyClient.js @@ -730,8 +730,7 @@ const ChatSource = new Lang.Class({ _ackMessages: function() { // Don't clear our messages here, tp-glib will send a // 'pending-message-removed' for each one. - this._channel.ack_all_pending_messages_async(Lang.bind(this, function(src, result) { - this._channel.ack_all_pending_messages_finish(result);})); + this._channel.ack_all_pending_messages_async(null); } });